add server/metrics tests

server/metrics/counter_test.go

@@ -0,0 +1,21 @@
+package metrics
+
+import (
+	"testing"
+
+	"github.com/uber-go/tally"
+)
+
+func TestInitCounter(t *testing.T) {
+	scope := tally.NewTestScope("test", nil)
+
+	InitCounter(scope, "counter")
+
+	counter, ok := scope.Snapshot().Counters()["test.counter+"]
+	if !ok {
+		t.Errorf("Counter not found")
+	}
+	if counter.Value() != 0 {
+		t.Errorf("Counter is not initialized")
+	}
+}

server/metrics/scope.go

@@ -45,7 +45,7 @@ func newReporter(cfg valid.Metrics, logger logging.SimpleLogging) (tally.BaseSta
 
 	// return statsd metrics if configured
 	if cfg.Statsd != nil {
-		return newStatsReporter(cfg, logger)
+		return newStatsReporter(cfg)
 	}
 
 	// return prometheus metrics if configured
@@ -58,7 +58,7 @@ func newReporter(cfg valid.Metrics, logger logging.SimpleLogging) (tally.BaseSta
 
 }
 
-func newStatsReporter(cfg valid.Metrics, logger logging.SimpleLogging) (tally.StatsReporter, error) {
+func newStatsReporter(cfg valid.Metrics) (tally.StatsReporter, error) {
 
 	statsdCfg := cfg.Statsd