add copyright notice and some code remarks

ruleant · Nov 10, 2019 · 5d9e92e · 5d9e92e
1 parent 7216a72
commit 5d9e92e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,4 +1,5 @@
  v0.7 (not released yet)
+ - issue #73 : add form to manually enter a location, thanks to Timotheos Constambeys
  - translated to Ukrainian, thanks to Oleksiy
  - translated to Turkish, thanks to Mesut Akcan
 

diff --git a/res/values/strings.xml b/res/values/strings.xml
@@ -37,7 +37,7 @@
     <string name="location_longitude">Location longitude</string>
     <string name="cancel">Cancel</string>
     <string name="store_location">Store Location</string>
-    <string name="enter_location">Enter Location</string>
+    <string name="enter_location">Enter destination manually</string>
     <string name="rename_destination">Rename destination</string>
     <string name="store_location_disabled">Unable to store location if there is no current location</string>
     <string name="enter_location_invalid_latitude">Latitude is outside the valid range [-90°,90°]</string>

diff --git a/src/java/com/github/ruleant/getback_gps/AbstractGetBackGpsActivity.java b/src/java/com/github/ruleant/getback_gps/AbstractGetBackGpsActivity.java
@@ -2,6 +2,7 @@
  * Main Activity
  *
  * Copyright (C) 2012-2019 Dieter Adriaenssens
+ * Copyright (C) 2019 Timotheos Constambeys
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -312,7 +313,7 @@ public final void enterLocation() {
                 = (EditText) dialogView.findViewById(R.id.location_longtitude);
         // Set the layout for the dialog
         builder.setView(dialogView)
-                .setTitle(R.string.store_location)
+                .setTitle(R.string.enter_location)
                 .setPositiveButton(R.string.store_location,
                         new DialogInterface.OnClickListener() {
                             public void onClick(final DialogInterface dialog,
@@ -529,7 +530,7 @@ public boolean onPrepareOptionsMenu(final Menu menu) {
         if (isBound()) {
             // enable store location button if a location is set
             miStoreLocation.setEnabled(mService.getLocation() != null);
-            miEnterLocation.setEnabled(mService.getLocation() != null);
+            miEnterLocation.setEnabled(true);
             // enable store location button if a location is set
             miRenameDest.setEnabled(mService.getDestination() != null);
         }

diff --git a/src/java/com/github/ruleant/getback_gps/LocationService.java b/src/java/com/github/ruleant/getback_gps/LocationService.java
@@ -2,6 +2,7 @@
  * Location Service
  *
  * Copyright (C) 2012-2019 Dieter Adriaenssens
+ * Copyright (C) 2019 Timotheos Constambeys
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by