fix: also dynamically adjust URL in settings page

rugk · May 13, 2021 · 8773818 · 8773818
1 parent 8fe1a92
commit 8773818
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 23 deletions.
diff --git a/src/common/modules/BrowserCompat.js b/src/common/modules/BrowserCompat.js
@@ -0,0 +1,27 @@
+/**
+ * Helper functions useful for ensuring browser compatibility.
+ *
+ * @public
+ * @module BrowserCompat
+ */
+
+/**
+ * Returns a value based on what browser this is running in.
+ *
+ * @private
+ * @param  {Object} switchBrowser an object with values to return per browser
+ * @returns {string}
+ */
+export async function getBrowserValue(switchBrowser) {
+    if (browser.runtime.getBrowserInfo) {
+        const browserInfo = await browser.runtime.getBrowserInfo();
+
+        if (browserInfo.name === "Thunderbird") {
+            return switchBrowser.thunderbird;
+        } else {
+            return switchBrowser.firefox;
+        }
+    } else {
+        return switchBrowser.chrome;
+    }
+}
diff --git a/src/common/modules/data/Tips.js b/src/common/modules/data/Tips.js
@@ -81,7 +81,8 @@
  * @return {boolean|null}
  */
 
-import {userSpeaksLocaleNotYetTranslated} from "../LanguageHelper.js";
+import { userSpeaksLocaleNotYetTranslated } from "../LanguageHelper.js";
+import { getBrowserValue } from "../BrowserCompat.js";
 
 /**
  * An array of all tips.
@@ -169,27 +170,6 @@ const tipArray = [
     }
 ];
 
-/**
- * Returns a value based on what browser this is running in.
-
- * @private
- * @param  {Object} switchBrowser an object with values to return per browser
- * @returns {string}
- */
-async function getBrowserValue(switchBrowser) {
-    if (browser.runtime.getBrowserInfo) {
-        const browserInfo = await browser.runtime.getBrowserInfo();
-
-        if (browserInfo.name === "Thunderbird") {
-            return switchBrowser.thunderbird;
-        } else {
-            return switchBrowser.firefox;
-        }
-    } else {
-        return switchBrowser.chrome;
-    }
-}
-
 // freeze the inner tip objects, this is strongly recommend
 tipArray.forEach((object) => Object.freeze(object));
 

diff --git a/src/options/options.html b/src/options/options.html
@@ -61,7 +61,7 @@ <h1 data-i18n="__MSG_titleUnicodeAutocorrection__">Unicode autocorrection</h1>
 					Only the quotes replacement is done immediately.
 				</span><br>
 					<span class="helper-text" data-i18n="__MSG_optionHelperTextAutocorrectionEmoji__"  data-opt-i18n-keep-children>
-					For Emoji autocorrection, including <code data-i18n="__MSG_optionHelperTextAutocorrectionEmojiColonsCode__">:colon:</code> shortcodes and Emoticons, please also try out our <a href="https://addons.mozilla.org/firefox/addon/awesome-emoji-picker/" data-i18n="__MSG_optionHelperTextAutocorrectionEmojiLinkText__"  data-i18n-href="__MSG_optionHelperTextAutocorrectionEmojiLink__">🤩&nbsp;Awesome Emoji Picker</a> add-on.
+					For Emoji autocorrection, including <code data-i18n="__MSG_optionHelperTextAutocorrectionEmojiColonsCode__">:colon:</code> shortcodes and Emoticons, please also try out our <a id="link-awesome-emoji" data-i18n="__MSG_optionHelperTextAutocorrectionEmojiLinkText__">🤩&nbsp;Awesome Emoji Picker</a> add-on.
 					</span>
 
 					<li>

diff --git a/src/options/options.js b/src/options/options.js
@@ -5,6 +5,7 @@
  */
 
 import { tips } from "/common/modules/data/Tips.js";
+import { getBrowserValue } from "/common/modules/BrowserCompat.js";
 import * as AddonSettings from "/common/modules/AddonSettings/AddonSettings.js";
 import * as AutomaticSettings from "/common/modules/AutomaticSettings/AutomaticSettings.js";
 import * as RandomTips from "/common/modules/RandomTips/RandomTips.js";
@@ -20,3 +21,11 @@ RandomTips.init(tips).then(() => {
     RandomTips.setContext("options");
     RandomTips.showRandomTipIfWanted();
 });
+
+getBrowserValue({
+    firefox: "https://addons.mozilla.org/firefox/addon/awesome-emoji-picker/?utm_source=unicodify-addon&utm_medium=addon&utm_content=unicodify-addon-settings-inline&utm_campaign=unicodify-addon-settings-inline",
+    thunderbird: "https://addons.thunderbird.net/thunderbird/addon/awesome-emoji-picker/reviews/?utm_source=unicodify-addon&utm_medium=addon&utm_content=unicodify-addon-settings-inline&utm_campaign=unicodify-addon-settings-inline",
+    chrome: "https://chrome.google.com/webstore/detail/awesome-emoji-picker/",
+}).then((browserUrl) => {
+    document.getElementById("link-awesome-emoji").href = browserUrl;
+});