Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend MessageHandler for showing multiple messages #9

Closed
rugk opened this issue Apr 14, 2018 · 4 comments
Closed

Extend MessageHandler for showing multiple messages #9

rugk opened this issue Apr 14, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rugk
Copy link
Owner

rugk commented Apr 14, 2018

Currently MessageHandler can only show one message.

In the future, it could be necessary to show multiple messages, so these have to be created.

What has to be done?

  • dynamically clone HTML elements
  • maybe get away from IDs in these, as when they are cloned they are not unique anymore, maybe a class may be better
@rugk rugk added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2018
@rugk
Copy link
Owner Author

rugk commented Apr 19, 2018

It should maybe best be done by adding custom message types in the JS and thus all other functions can then be used as usual. (maybe they also need some expansions though)

@rugk
Copy link
Owner Author

rugk commented Apr 25, 2018

I'd say this is rather low-prio right now, because I have no need for moire message types/custom messages. Currently one is always enough. 😃

@rugk rugk removed the good first issue Good for newcomers label May 13, 2018
@rugk
Copy link
Owner Author

rugk commented May 13, 2018

BTW with #79, I've changed the message handler a bit and it now also allows to pass in custom HTML elements. It still not really swallow cloning of one message type or so, but my use cases for it are covered by the current behaviour…

@rugk
Copy link
Owner Author

rugk commented Jun 1, 2018

I'll do this with what i mentioned here.

@rugk rugk added this to the 1.2 milestone Jun 1, 2018
@rugk rugk self-assigned this Jun 2, 2018
@rugk rugk closed this as completed in d26bf4f Jun 2, 2018
daaAd1 pushed a commit to daaAd1/offline-qr-code that referenced this issue Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant