Skip to content

Commit

Permalink
update cors
Browse files Browse the repository at this point in the history
  • Loading branch information
rugglcon committed Aug 24, 2019
1 parent 9907e8d commit 341f2f7
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
6 changes: 4 additions & 2 deletions src/routes/budget.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import { BudgetLogic } from '../logic/budgets';
import { Budget, NewBudget, SimpleBudget } from '../data/entities/budget';
import { User } from 'data/entities/user';
import { ExpenseLogic } from 'logic/expenses';
import cors = require('cors');

export const budgetRoutes = (cors: () => RequestHandler, budgetLogic: BudgetLogic, expenseLogic: ExpenseLogic): Router => {
export const budgetRoutes = (appCors: (options?: cors.CorsOptions | cors.CorsOptionsDelegate) => RequestHandler,
budgetLogic: BudgetLogic, expenseLogic: ExpenseLogic): Router => {
const budgetsRouter = Router();

// budgetsRouter.all('*', cors());
budgetsRouter.all('*', appCors({ origin: true, credentials: true }));

// validates that id is a number
budgetsRouter.param('id', (_req, res, next, id) => {
Expand Down
8 changes: 6 additions & 2 deletions src/routes/expense.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import { Expense } from '../data/entities/expense';
import { ExpenseLogic } from '../logic/expenses';
import logger from '../util/logger';
import { User } from 'data/entities/user';
import cors = require('cors');

export const expenseRoutes = (cors: () => RequestHandler,
export const expenseRoutes = (appCors: (options?: cors.CorsOptions | cors.CorsOptionsDelegate) => RequestHandler,
budgetLogic: BudgetLogic,
expenseLogic: ExpenseLogic): Router => {
const expensesRouter = Router();
Expand All @@ -22,7 +23,10 @@ export const expenseRoutes = (cors: () => RequestHandler,
}
});

// expensesRouter.all('*', cors());
expensesRouter.all('*', appCors({
origin: true,
credentials: true
}));

// creates an expense
expensesRouter.post('/', async (req, res) => {
Expand Down
5 changes: 3 additions & 2 deletions src/routes/user.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ import { PassportStatic } from 'passport';
import { UserLogic } from 'logic/users';
import { AuthLogic } from 'logic/auth';
import logger from '../util/logger';
import cors = require('cors');

/**
* Creates the user routes
*/
export const userRoutes = (cors: () => RequestHandler, passport: PassportStatic,
export const userRoutes = (appCors: (options?: cors.CorsOptions | cors.CorsOptionsDelegate) => RequestHandler, passport: PassportStatic,
userLogic: UserLogic, authLogic: AuthLogic): Router => {
const userRouter = Router();

Expand All @@ -22,7 +23,7 @@ export const userRoutes = (cors: () => RequestHandler, passport: PassportStatic,
}
});

// userRouter.all('*', cors({ origin: true, credentials: true }));
userRouter.all('*', appCors({ origin: true, credentials: true }));

// logs a user in
userRouter.post(
Expand Down

0 comments on commit 341f2f7

Please sign in to comment.