Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM2: Partially support parentAllowsChild when domains match #19521

Merged
merged 1 commit into from
Feb 22, 2025
Merged

AVM2: Partially support parentAllowsChild when domains match #19521

merged 1 commit into from
Feb 22, 2025

Conversation

adrian17
Copy link
Collaborator

Partially addresses #14455 .

The window now kinda works, though it's slow, leaks memory (known unload() issues) and sometimes hangs after throwing:

2025-02-14T22:19:50.642618Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b73e00, name: "src.com.gaiaonline.FishTank.services::SpecialEventManager/onGetSettings()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: events)
        at src.com.gaiaonline.FishTank.services::SpecialEventManager/onGetSettings()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()
2025-02-14T22:19:50.642730Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b76800, name: "FishTank/onUserEnvironment()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: user_id)
        at FishTank/onUserEnvironment()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()
2025-02-14T22:19:50.642782Z ERROR ruffle_core::avm2::events: Error dispatching event EventObject { type: "getUserEnvironment", class: src.com.gaiaonline.FishTank.events::DataConnectorEvent, ptr: 0x2a5c77646f0 } to handler FunctionObject(FunctionObject { ptr: 0x2a5c5b77900, name: "src.com.gaiaonline.FishTank.miniGames::GameManager/onUserEnvironment()" }) : TypeError: Error #1010: A term is undefined and has no properties. (accessing field: game_info)
        at src.com.gaiaonline.FishTank.miniGames::GameManager/onUserEnvironment()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at src.com.gaiaonline.FishTank.services::DataConnector/onGSILoaded()
        at flash.events::EventDispatcher/dispatchEventInternal()
        at flash.events::EventDispatcher/dispatchEvent()
        at com.gaiaonline.gsi::GSIGateway/onComplete()

@torokati44 torokati44 added A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already) labels Feb 19, 2025
@adrian17 adrian17 requested a review from kjarosh February 20, 2025 18:19
kjarosh
kjarosh approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@kjarosh kjarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrian17 adrian17 force-pushed the avm2-loaderinfo-partial-allows-child branch from 981ba09 to b57897e Compare February 22, 2025 19:06
@adrian17 adrian17 enabled auto-merge (rebase) February 22, 2025 19:06
@adrian17 adrian17 merged commit 643998c into ruffle-rs:master Feb 22, 2025
22 checks passed
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Feb 23, 2025
@Hancock33
Updates on Feb 23, 2025 06:59
abf32c4 
------------------------------------------------------------------------------------------
dolphin-emu.mk 6d9c887a214f4fec16779f9ecbec555948ef94cd # Version: Commits on Feb 23, 2025
------------------------------------------------------------------------------------------
Merge pull request #13365 from jordan-woyak/si-disco

SI: Set NOREP, ERRSTAT, and ERRLATCH when GetData returns false.,

---------------------------------------------------------------------------------------------
dosbox-staging.mk c43233c55abc31fd23cd3bd48086c7228ae658d7 # Version: Commits on Feb 22, 2025
---------------------------------------------------------------------------------------------
website: Add 0.82.1 release notes draft,

----------------------------------------------------
pcsx2.mk v2.3.171 # Version: Commits on Feb 23, 2025
----------------------------------------------------
- [GS/HW: Increase Merge Sprite paving sensitivity to avoid mismerges](PCSX2/pcsx2#12345)

,

---------------------------------------------------------------
ruffle.mk nightly-2025-02-23 # Version: Commits on Feb 23, 2025
---------------------------------------------------------------
## What's Changed

* chore: Update translations by @RuffleBuild in ruffle-rs/ruffle#19573

* render: Remove `Rc` around `wgpu` objects by @a1phyr in ruffle-rs/ruffle#19587

* AVM2: Partially support parentAllowsChild when domains match by @adrian17 in ruffle-rs/ruffle#19521

* render: Switch to wgpu fork with backported GLES limits fix by @adrian17 in ruffle-rs/ruffle#19512

* avm2: Fix panic on loading sounds multiple times by @kjarosh in ruffle-rs/ruffle#19586

* avm2: Various fixes and code improvements by @Lord-McSweeney in ruffle-rs/ruffle#19589

* core: Rename display objects' `static_data` field to `shared` by @moulins in ruffle-rs/ruffle#19595

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-02-22...nightly-2025-02-23,

-----------------------------------------------------
ryujinx.mk 1.2.414 # Version: Commits on Feb 23, 2025
-----------------------------------------------------
# Canary builds:

These builds are experimental and may sometimes not work, use [regular builds](https://github.com/Ryubing/Ryujinx/releases/latest) instead if that sounds like something you don't want to deal with.

| Platform | Artifact |

|--|--|

| Windows 64-bit | [Canary Windows Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.414/ryujinx-canary-1.2.414-win_x64.zip) |

| Linux 64-bit | [Canary Linux Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.414/ryujinx-canary-1.2.414-linux_x64.tar.gz) |

| Linux ARM 64-bit | [Canary Linux ARM Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.414/ryujinx-canary-1.2.414-linux_arm64.tar.gz) |

| macOS | [Canary macOS Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.2.414/ryujinx-canary-1.2.414-macos_universal.app.tar.gz) |

**Full Changelog**: Ryubing/Ryujinx@Canary-1.2.413...Canary-1.2.414

--------------------------------------------------------------------------------------
shadps4.mk 4f1baece33c6c324a14b22508d5755f7ac6885dd # Version: Commits on Feb 23, 2025
--------------------------------------------------------------------------------------
Avoid processing job buffers before codec initialization (#2507),

---------------------------------------------------------------------------------------
thextech.mk 5e0a4675c3c010d0727d7dc300ad425fbe64e3e8 # Version: Commits on Feb 23, 2025
---------------------------------------------------------------------------------------
frm_main.cpp: temporarily revert forced exclusive fullscreen,

---------------------------------------------------------------------------------------
corsixth.mk 1659cac64c5b0e6b642b6ae5dd4e187ec5139e97 # Version: Commits on Feb 22, 2025
---------------------------------------------------------------------------------------
Merge pull request #2782 from lewri/lightness_typo

Fix typo in lightness calculation,

--------------------------------------------------------------------------------------
eduke32.mk 1357a62291ad506a33b6efb3d67fa856bec81cae # Version: Commits on Feb 11, 2025
--------------------------------------------------------------------------------------
Add includeoptional CON token, that doesn't error out if the included file is absent.

---------------------------------------------------------------------------------------
etlegacy.mk d84858eb911f1264fe46c7466f78d1edb365eefa # Version: Commits on Feb 23, 2025
---------------------------------------------------------------------------------------
app: add missing incrementation, we have working theme switcher,

----------------------------------------------------------------------------------------
doomretro.mk 4da8df39c311386c6e7fd6f36c4dcbdfe6cd458e # Version: Commits on Feb 23, 2025
----------------------------------------------------------------------------------------
Fix pressing use key to accelerate intermission sometimes failing,

------------------------------------------------------------------------------------------
xash3d-fwgs.mk ccf342f4fe94c442f65be83ab82accd4cfad8eff # Version: Commits on Feb 23, 2025
------------------------------------------------------------------------------------------
engine: client: fix inconsistent mouse state caused by mis-use of touch_emulate by cs16-client,

------------------------------------------------------------------------------------------------
libretro-nestopia.mk 72003d06eb9fbc2191f5a7a874abc039bde3157f # Version: Commits on Feb 23, 2025
------------------------------------------------------------------------------------------------
limit paddle range (#96)

Add options for the range so users can match it exactly to the game,

--------------------------------------------------------------------------------------------
libretro-pcsx.mk 73a3ca2ca468dbc6bd8c524c9709617662d5b105 # Version: Commits on Feb 23, 2025
--------------------------------------------------------------------------------------------
Merge branch 'master' into libretro,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjarosh kjarosh kjarosh approved these changes

Assignees
No one assigned
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian17 @kjarosh @torokati44