Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop correction #6

Merged
merged 1 commit into from
Feb 26, 2024
Merged

loop correction #6

merged 1 commit into from
Feb 26, 2024

Conversation

CrocHold
Copy link
Contributor

correct order of conditions, to avoid runtime errors

@rueian
Copy link
Owner

rueian commented Feb 15, 2024

Hi @CrocHold, the change looks good to me. I just wonder what message made you run into the runtime error?

@CrocHold
Copy link
Contributor Author

The runtime panic arose in my case when either the client or the server, deviates from following the latest handshake protocol.
It happened since pgbroker cant stay stateless at all times w.r.t. the next message arriving. (SASL's case)
And has to assume it & decide the next handler beforehand, storing it in context.

@rueian
Copy link
Owner

rueian commented Feb 26, 2024

Got it, thanks for the explanation!

@rueian rueian merged commit 8bf535b into rueian:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants