Test with rails 5.1 and ruby 2.4.0 #393
Conversation
|
@mfazekas awesome! Are you able to remove Rails 4.1 actually? We drop support as new rails versions come out :). (Keeps the CI fast and makes adding new features or fixing bugs easier for everyone.) |
794fa8d to
976aa7e
Compare
|
I've removed 4.1 from travis. (In case you actually break 4.1 you might want to increase major version because of SemVer) |
.travis.yml
Outdated
| @@ -5,22 +5,27 @@ rvm: | |||
| - 2.1.10 | |||
There was a problem hiding this comment.
Man, I remember the day when I was super excited for Ruby 2.1, but nowadays I think we can even remove this from Travis as well. 2.2 is quite compatible and gives that restriction from the ?. operator.
.travis.yml
Outdated
| @@ -5,22 +5,27 @@ rvm: | |||
| - 2.1.10 | |||
| - 2.2.6 | |||
| - 2.3.3 | |||
| - 2.4.0 | |||
There was a problem hiding this comment.
I don't want to keep asking you to keep going back and making changes to something that should be quite simple... But, it looks like the latest is 2.4.1 :p
|
Merged. I just realized, your commit is a lie now :p lol |
|
Why is Rails 5.1.0 not being tested with Ruby 2.2? |
|
@aried3r i guess it was an overlook |
…sociations This `defined?(super)` check was introduced for Rails 4.1 support rubysherpas#390 (comment) but we've stopped supporting Rails 4.1 already rubysherpas#393 (comment)
Updated travis.yml with rails 5.1 and ruby 2.4