This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
Expose Gumbo parse errors to Nokogiri document. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the internal Gumbo error API to get error parse error information. Expose this to Ruby by crafting an array of `Nokogiri::XML::SyntaxError` objects filled in with a variety of information, including column and line information. These are stored in the document's `@errors` instance variable. Note that since the HTML state machine completely specifies what to do on every parse error, no error is fatal.
eb59c58 to
e361b49
Compare
|
By the by, Ruby 2.0 and earlier have passed their end of life and 2.1 will only receive security bug fixes. |
Closed
|
Hey @rubys! Could we get a gem release so we can start depending on this API? (Would be wonderful to get a toplevel .gemspec, too, so we can bundle from git between gem releases!) |
Can you give http://intertwingly.net/tmp/nokogumbo-1.4.10.gem a test drive? This gem has a history of problems that only show up on some configurations (most notably, Gentoo, but at times some versions of Mac OS/X).
Patches welcome! :-) |
👍 Package is near-identical to the 1.4.10 gem I built locally. Compiles cleanly and tests pass and Ruby 2.4 and 2.3. (Background: taking a stab at adding HTML5 support to html-proofer 😊) |
|
pushed |
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Nov 1, 2016
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
4 tasks
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Nov 2, 2016
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Nov 2, 2016
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Feb 15, 2017
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
May 17, 2017
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Sep 4, 2018
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
jeremy
added a commit
to jeremy/html-proofer
that referenced
this pull request
Sep 4, 2018
Introduces `--report-missing-doctype`, defaulting to false, to report on missing `<!DOCTYPE html>` at the beginning of the document. Depends on Nokogumbo >= 1.4.10 for rubys/nokogumbo#46 Fixes gjtorikian#318.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the internal Gumbo error API to get error parse error information. Expose
this to Ruby by crafting an array of
Nokogiri::XML::SyntaxErrorobjects filledin with a variety of information, including column and line information. These
are stored in the document's
@errorsinstance variable.Note that since the HTML state machine completely specifies what to do on
every parse error, no error is fatal.