Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trade page handle high load (#38) #70

Open
wants to merge 4 commits into
base: 1-8-stable
Choose a base branch
from

Conversation

ritesh-skyach
Copy link
Contributor

[WIP] Trade page is broken under high load #38

@yivo yivo added the PR: QA label Jun 13, 2018
@yivo yivo changed the title [WIP] #38 Trade page is broken under high load Make trade page handle high load (#38) Jun 13, 2018
@pkucherenk0
Copy link

@ritesh-skyach the completed trades will not be displayed in the panel, under heavy load, without manual refresh of the page.
https://streamable.com/9tnbz

@yivo yivo added PR: WIP and removed PR: QA labels Jun 14, 2018
@yivo
Copy link
Contributor

yivo commented Jun 15, 2018

@ritesh-skyach Please rebase.

@ritesh-skyach
Copy link
Contributor Author

@yivo Sure.

@ritesh-skyach
Copy link
Contributor Author

@pkucherenk0 I have tested this and not facing such issue, Can you please let me know what options you are using with stress test tool
My options are --orders 10000 --traders 100 --threads 10
Here is my output https://streamable.com/hqbbz

@ritesh-skyach
Copy link
Contributor Author

@yivo Done.

@pkucherenk0
Copy link

@ritesh-skyach Im using api calls to create a lot of small orders with the same bid or ask price and then match them all, at the same time from another account.
The completed orders will not appear in the completed orders panel right away but after +-30 seconds after all trades was processed in a couple of waves with 5 second period.

What is interesting tho, is that single matched order will be displayed in the completed orders panel right away, but after updating the page will disappear.

@pkucherenk0
Copy link

It became worth. Now, not only the account which was doing the tons of trades have freezed trading ui, but all user experience this issue.
I might over load instead of high load the trading ui. But at the moment, nothing can stop user to sell 1 Coin with little transactions, like 0.00000001 Coin. And by doing that ruin the trading for every one.
Here what not involved in trades user will see on the trading ui for next 5 min or so:
selection_427

@ritesh-skyach
Copy link
Contributor Author

@pkucherenk0, Please can you share your script which produces this issue. As I am trying to reproduce this issue on my local machine using toolbox/stress testing and was not able to reproduce this locally.

Ritesh Chohda added 2 commits June 29, 2018 18:25
@huuhait
Copy link

huuhait commented Oct 24, 2018

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants