bump required ruby version to >= 2.6 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamSaffron I'm fine with it. I don't rely on mini_racer directly yet and still have some stuff to upstream before I can do that, so there's no reason to change the current policy right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 06cca5b#diff-30d3134eb72fcd96ce343d5c0359684a5545843b47d7cba45732d3e360cf322f the required ruby version was bumped to >= 2.5.
I just stumbled across Ruby Maintenance Branches where it lists Ruby 2.5's EOL date to 2021-03-31. Based on @SamSaffron's comment and the README stating that only non-EOL'd versions of Ruby will be supported, I guess, we could bump the version once more?
It's just a suggestion, I just stumbled across the Ruby maintenance overview.