Use Rubocop plugin for CodeClimate. #3200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3200 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 110 110
Lines 3310 3310
=======================================
Hits 3250 3250
Misses 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -1,17 +1,4 @@ | |||
| version: "2" | |||
There was a problem hiding this comment.
I believe we need to keep the version number here
| plugins: | ||
| rubocop: | ||
| enabled: true | ||
| channel: "rubocop-1-23-0" |
There was a problem hiding this comment.
Do we need to specify the version of rubocop that is run? Or in other words, do you know the default version that is used.
There was a problem hiding this comment.
some ancient one like 0.49 :-o
|
Actually we can remove codeclimate at all if I understand it well now. Codecov is doing its job well and rubocop is being checked at CI. |
|
I used this for a while but eventually gave up, mainly due to codeclimate/codeclimate-rubocop#93. If we can get rid of codeclimate, I would do it. |
|
let's remove CC |
CodeClimate has custom configuration. Currently we lint using Rubocop and code coverage is done using CI CodeCov action. We can give up on CodeClimate at all or try to follow rubocop rules (I'm tryin this in this PR).