Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use superscript star for a rubygem version date with a tooltip #3193

Conversation

nvasilevski
Copy link
Contributor

@nvasilevski nvasilevski commented Aug 23, 2022

Addresses #3115 (comment)

Use a superscript start next to an imported version instead of the [?] symbol to indicate presence of a tooltip

New look:
image

One thing is that maybe we should put the superscript star next to the release date instead of the version number as the date is the piece that has special meaning for these versions ✅ Done

cc: @sonalkr132

@simi
Copy link
Member

simi commented Aug 23, 2022

@nvasilevski ℹ️ rebase against master will fix CI. Sorry for the troubles.

@nvasilevski nvasilevski force-pushed the add-superscript-start-for-tooltiped-version-numbers branch from 2899638 to 2f4b7bd Compare August 23, 2022 18:25
@sonalkr132
Copy link
Member

we should put the superscript star next to the release date instead of the version number as the date is the piece that has special meaning for these versions

Makes sense 👍

@nvasilevski nvasilevski marked this pull request as draft August 23, 2022 21:14
@nvasilevski
Copy link
Contributor Author

Marking as a draft while I'm moving the superscript to the date instead of the version number. Sorry for the noise

@simi
Copy link
Member

simi commented Aug 23, 2022

Sorry for the noise

no worries, take your time

@nvasilevski nvasilevski force-pushed the add-superscript-start-for-tooltiped-version-numbers branch from 2f4b7bd to 43716ce Compare August 24, 2022 18:05
@nvasilevski nvasilevski changed the title Use superscript star for a rubygem version with a tooltip Use superscript star for a rubygem version date with a tooltip Aug 24, 2022
@nvasilevski nvasilevski marked this pull request as ready for review August 24, 2022 18:07
@nvasilevski
Copy link
Contributor Author

nvasilevski commented Aug 24, 2022

Moved the asterisk to the date, updated the screenshot

Pushing while PR is in a draft doesn't seem to trigger CI so let me force-push once again I think it was something else, perhaps wrong CI config, had to rebase to fix it

@nvasilevski nvasilevski force-pushed the add-superscript-start-for-tooltiped-version-numbers branch from 43716ce to f0b18f5 Compare August 24, 2022 18:09
@nvasilevski nvasilevski force-pushed the add-superscript-start-for-tooltiped-version-numbers branch from f0b18f5 to 07fd8a2 Compare August 24, 2022 18:10
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #3193 (07fd8a2) into master (9277173) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3193   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         110      110           
  Lines        3309     3310    +1     
=======================================
+ Hits         3249     3250    +1     
  Misses         60       60           
Impacted Files Coverage Δ
app/helpers/versions_helper.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simi simi requested a review from sonalkr132 August 25, 2022 12:51
@sonalkr132 sonalkr132 merged commit dee7118 into rubygems:master Aug 25, 2022
@sonalkr132
Copy link
Member

Thank you @nvasilevski

@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging August 25, 2022 14:23 Inactive
@nvasilevski nvasilevski deleted the add-superscript-start-for-tooltiped-version-numbers branch August 25, 2022 14:48
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production August 26, 2022 03:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants