Migrate Partners Controller Spec to Request Spec #180
Conversation
|
Thank you so much for this contribution @lucianolima00! I just got back from a vacation this week and Ive been doing alot of catch up. Ill make sure to give this PR a thorough review this weekend! 😄 In the meantime, could you take a look at the TravisCI failiures? (if not, I can look when I get around to reviewing this.) |
|
@benreyn Of course, I'll take a look |
|
@benreyn If it don't be a problem to you, I'll organize my commits, because my git got crazy and changed my name to |
There was a problem hiding this comment.
Thanks so much for your work on this @lucianolima00. I made some comments about readability and code style that are mostly personal preference. If I dont hear from you in a few days Ill go ahead and merge as is. Thanks again! 😄
|
I tried to solve the problems using the controller spec as reference. Comment if there's anything yet |
|
@lucianolima00, looks like rubocop got you. Your should be able to fix the build by running |
|
It looks like you have some merge conflicts here @lucianolima00. Once those are resolved we can get this in. 😄 |
Resolves #173
Description
Migrate the spec PartnerController to Request Spec
Type of change
How Has This Been Tested?
Running specs