This repository has been archived by the owner on Nov 6, 2021. It is now read-only.
Upgrade to Rails 6 #176
Closed
Upgrade to Rails 6 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cassianoblonski, Are you still working on this? Can you take a look at the merge conflicts and CI failures? |
|
I'll look at it |
|
Closing this as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167
Description
Make the necessary adjustments to upgrade rails to the new major release. Below you can keep track of the status of this issue:
Provide WIP-Pull Request of
upgrade-to-rails-6branchTest Coverage: Partner Requests Controller #149 Convert partners_requests_controller_spec.rb to request spec
Migrate Partners Controller Spec to Request Spec #173 Convert partners_controller_spec.rb to request spec
Add specs to partner requests controllers #175 Convert static_controller_spec.rb to request spec
Type of change
How Has This Been Tested?
Running all the tests green (except for the 3 controller_specs mentioned that already needed migrations.