Require dry-validation only when schema is specified #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you never specify a schema, you're still paying the penalty of loading a rather large library. By waiting until someone specifies a schema to validate, we can reduce the config require time and object allocations by ~30% if you don't specify an optional schema. On my mac, bundle console is 30 MB before this change and around 23 MB after. Before: $ time be ruby -e "require 'config'; puts GC.stat[:total_allocated_objects]" 347010 bundle exec ruby -e "require 'config'; puts GC.stat[:total_allocated_objects] 0.54s user 0.17s system 98% cpu 0.722 total After: $ time be ruby -e "require 'config'; puts GC.stat[:total_allocated_objects]" 224764 bundle exec ruby -e "require 'config'; puts GC.stat[:total_allocated_objects] 0.38s user 0.12s system 98% cpu 0.508 total
d18bfda to
2efdf62
Compare
|
The rails 4.2 test failures are fixed in #254 |
|
Looks great! Thanks! |
pkuczynski
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you never specify a schema, you're still paying the penalty of loading a
rather large library.
By waiting until someone specifies a schema to validate, we can reduce the
config require time and object allocations by ~30% if you don't specify an
optional schema. On my mac, bundle console is 30 MB before this change and
around 23 MB after.
Before:
$ time be ruby -e "require 'config'; puts GC.stat[:total_allocated_objects]"
347010
bundle exec ruby -e "require 'config'; puts GC.stat[:total_allocated_objects] 0.54s user 0.17s system 98% cpu 0.722 total
After:
$ time be ruby -e "require 'config'; puts GC.stat[:total_allocated_objects]"
224764
bundle exec ruby -e "require 'config'; puts GC.stat[:total_allocated_objects] 0.38s user 0.12s system 98% cpu 0.508 total