Merge pull request #531 from amatsuda/ApplicationHelper_in_controller

Avoid including ApplicationHelper in a controller
rubycentral · Mar 9, 2025 · 3ecfb44 · 3ecfb44
2 parents 046225a + 36922e7
commit 3ecfb44
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/controllers/proposals_controller.rb b/app/controllers/proposals_controller.rb
@@ -109,13 +109,12 @@ def update
     end
   end
 
-  include ApplicationHelper
   def parse_edit_field
     respond_to do |format|
       format.js do
         render locals: {
           field_name: params[:name],
-          text: markdown(params[:text])
+          text: params[:text]
         }
       end
     end

diff --git a/app/views/proposals/parse_edit_field.js.erb b/app/views/proposals/parse_edit_field.js.erb
@@ -1 +1 @@
-$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j text %>';
+$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j markdown(text) %>';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j text %>';
		$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j markdown(text) %>';