Fix: Safe call body method (DOM) when page is empty #522

Mihoid · 2025-02-19T12:30:38Z

In some cases method body (DOM) can raise an exception. It happens when page is empty and there is no html
e.g.

=> browser = ::Ferrum::Browser.new
=> browser.goto('https://somesitewithemptypage.com') # <—— here we receive empty page
=> browser.body 
=> 
Ferrum::JavaScriptError: TypeError: Cannot read properties of null (reading 'outerHTML') |

This PR will add safe call method body for reducing errors

Mihoid · 2025-02-19T20:50:11Z

spec/network_spec.rb

@@ -517,6 +517,6 @@
      %r{Request to http://.*/with_js failed \(net::ERR_INTERNET_DISCONNECTED\)}
    )

-    expect(page.at_css("body").text).to match("No internet")


these changes are a little bit confusing me 🤔

Mihoid force-pushed the fix/page-safe-call branch 2 times, most recently from 67d0baf to 01fa6ca Compare February 19, 2025 20:44

Mihoid commented Feb 19, 2025

View reviewed changes

Fix: Safe call body method (DOM) when page is empty

f22da55

Mihoid force-pushed the fix/page-safe-call branch from 01fa6ca to f22da55 Compare February 19, 2025 20:51

route merged commit 486a64a into rubycdp:main Feb 20, 2025
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Safe call body method (DOM) when page is empty #522

Fix: Safe call body method (DOM) when page is empty #522

Mihoid commented Feb 19, 2025

Mihoid Feb 19, 2025 •

edited

Loading

Fix: Safe call body method (DOM) when page is empty #522

Fix: Safe call body method (DOM) when page is empty #522

Conversation

Mihoid commented Feb 19, 2025

Mihoid Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

Mihoid Feb 19, 2025 •

edited

Loading