Merge pull request #158 from rubycdp/fix-build

Fix build

gemfiles/websocket-driver-0.6.x.gemfile → .github/gemfiles/websocket-driver-0.6.x.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "websocket-driver", "~> 0.6.5"
 
-gemspec path: "../"
+gemspec path: "../../"

gemfiles/websocket-driver-0.7.x.gemfile → .github/gemfiles/websocket-driver-0.7.x.gemfile

@@ -4,4 +4,4 @@ source "https://rubygems.org"
 
 gem "websocket-driver", "~> 0.7.1"
 
-gemspec path: "../"
+gemspec path: "../../"

.github/workflows/tests.yml

@@ -0,0 +1,38 @@
+name: Tests
+on: [push]
+
+jobs:
+  tests:
+    name: Tests
+
+    strategy:
+      fail-fast: false
+      matrix:
+        gemfile: [websocket-driver-0.6.x, websocket-driver-0.7.x]
+        ruby: [2.5, 2.6, 2.7]
+
+    runs-on: ubuntu-latest
+    env:
+      FERRUM_PROCESS_TIMEOUT: 20
+      BUNDLE_GEMFILE: .github/gemfiles/${{ matrix.gemfile }}.gemfile
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - run: mkdir -p /tmp/ferrum
+
+      - name: Run tests
+        run: bundle exec rake
+
+      - name: Archive artifacts
+        uses: actions/upload-artifact@v2
+        if: ${{ failure() }}
+        with:
+          name: footprints
+          path: /tmp/ferrum/

README.md

@@ -1,7 +1,5 @@
 # Ferrum - high-level API to control Chrome in Ruby
 
-[![CircleCI](https://circleci.com/gh/rubycdp/ferrum.svg?style=shield)](https://circleci.com/gh/rubycdp/ferrum)
-
 <img align="right"
      width="320" height="241"
      alt="Ferrum logo"

lib/ferrum/browser/process.rb

@@ -16,7 +16,7 @@ class Browser
     class Process
       KILL_TIMEOUT = 2
       WAIT_KILLED = 0.05
-      PROCESS_TIMEOUT = ENV.fetch("FERRUM_PROCESS_TIMEOUT", 2).to_i
+      PROCESS_TIMEOUT = ENV.fetch("FERRUM_PROCESS_TIMEOUT", 10).to_i
 
       attr_reader :host, :port, :ws_url, :pid, :command,
                   :default_user_agent, :browser_version, :protocol_version,

spec/browser_spec.rb

@@ -57,7 +57,7 @@ module Ferrum
       path = "#{PROJECT_ROOT}/spec/support/no_chrome"
 
       expect {
-        Browser.new(browser_path: path)
+        Browser.new(browser_path: path, process_timeout: 2)
       }.to raise_error(
         Ferrum::ProcessTimeoutError,
         "Browser did not produce websocket url within 2 seconds"

spec/spec_helper.rb

@@ -67,11 +67,10 @@ def save_exception_aftifacts(browser, meta)
     timestamp = "#{time_now.strftime("%Y-%m-%d-%H-%M-%S.")}#{"%03d" % (time_now.usec/1000).to_i}"
 
     screenshot_name = "screenshot-#{filename}-#{line_number}-#{timestamp}.png"
-    screenshot_path = "#{ENV["CIRCLE_ARTIFACTS"]}/screenshots/#{screenshot_name}"
+    screenshot_path = "/tmp/ferrum/#{screenshot_name}"
     browser.screenshot(path: screenshot_path, full: true)
 
-    log_name = "ferrum-#{filename}-#{line_number}-#{timestamp}.txt"
-    log_path = "#{ENV["CIRCLE_ARTIFACTS"]}/logs/#{log_name}"
-    File.open(log_path, "wb") { |file| file.write(FERRUM_LOGGER.string) }
+    log_name = "logfile-#{filename}-#{line_number}-#{timestamp}.txt"
+    File.open("/tmp/ferrum/#{log_name}", "wb") { |file| file.write(FERRUM_LOGGER.string) }
   end
 end