Add browserContextId for Browser.setDownloadBehavior

rubycdp · Apr 16, 2022 · 25712d1 · 25712d1
1 parent 6594c82
commit 25712d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/ferrum/page.rb b/lib/ferrum/page.rb
@@ -263,15 +263,13 @@ def prepare_page
 
       if @browser.options[:save_path]
         unless Pathname.new(@browser.options[:save_path]).absolute?
-          raise Error, "supply absolute path as `:save_path` option"
+          raise Error, "supply absolute path for `:save_path` option"
         end
 
         @browser.command("Browser.setDownloadBehavior",
+                         browserContextId: context.id,
                          downloadPath: browser.options[:save_path],
                          behavior: "allow", eventsEnabled: true)
-        command("Page.setDownloadBehavior",
-                downloadPath: browser.options[:save_path],
-                behavior: "allow")
       end
 
       @browser.extensions.each do |extension|

diff --git a/spec/download_spec.rb b/spec/download_spec.rb
@@ -29,7 +29,7 @@ module Ferrum
         it "raises an error" do
           expect do
             browser.go_to("/#{filename}")
-          end.to raise_error(Ferrum::Error, "supply absolute path as `:save_path` option")
+          end.to raise_error(Ferrum::Error, "supply absolute path for `:save_path` option")
         end
       end
     end