Rails3 #7
Merged
Rails3 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently a production killer. I migrated my apps for testing purposes to Rails 3.1beta and this patch would definitely help when being merged into core and into a new release. |
|
+1 |
1 similar comment
|
+1 |
|
+1 |
|
I believe this was fixed in 83702ca, no? Can someone confirm? I'm not running anything under 3.1 right now.... |
|
Looks like 83702ca was missing some additional fixes (Rails.logger, for example). I merged in this pull request with some changes. Can someone confirm that things are okay for Rails 3.1 now? |
|
Working here. Please bump the gem version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed deprecated RAILS_DEFAULT_LOGGER to Rails.logger for rails 3.1