Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting folder_privacy violation #53

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Reporting folder_privacy violation #53

merged 1 commit into from
Aug 29, 2024

Conversation

perryqh
Copy link
Contributor

@perryqh perryqh commented Aug 29, 2024

Reporting folder_privacy violations.

@perryqh perryqh changed the title Adding folder_privacy violation Reporting folder_privacy violation Aug 29, 2024
@@ -981,7 +981,7 @@ module PackStats # rubocop:disable RSpec/DescribedClassModuleWrapping
expect(metrics).to include_metric GaugeMetric.new(name: 'modularization.by_package.public_files.count', count: 0, tags: Tags.for(['package:packs/only_package', 'app:MyApp', 'team:Unknown', 'max_enforcements:true'])) end
end

context 'in app with architectural enforcements' do
context 'in app with layer enforcements' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@perryqh perryqh force-pushed the ph/add-folder-privacy branch from 4d09319 to 81af607 Compare August 29, 2024 19:22
@perryqh perryqh merged commit 2ff28c3 into main Aug 29, 2024
4 checks passed
@perryqh perryqh deleted the ph/add-folder-privacy branch August 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants