Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup bundler version for rubies with bundler as a default gem #118

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Dec 4, 2020

Basically use specific bundler version until lockfile is created. Fixes #117, test run which previously failed can be found here.

@eregon
Copy link
Member

eregon commented Dec 5, 2020

The failed log is actually https://github.com/ojab/watir-rails/runs/1500383889?check_suite_focus=true

  /opt/hostedtoolcache/Ruby/2.6.3/x64/bin/bundle lock
  Fetching gem metadata from https://rubygems.org/...........
  Fetching gem metadata from https://rubygems.org/.
  Resolving dependencies...
  Bundler could not find compatible versions for gem "bundler":
    In Gemfile.rails-4.x:
      rails (~> 4.0) was resolved to 4.2.11.3, which depends on
        bundler (>= 1.3.0, < 2.0)
  
    Current Bundler version:
      bundler (2.1.4)
  This Gemfile requires a different version of Bundler.
  Perhaps you need to update Bundler by running `gem install bundler`?
  
  Could not find gem 'bundler (>= 1.3.0, < 2.0)', which is required by gem 'rails
  (~> 4.0)', in any of the sources.
  
  Bundler could not find compatible versions for gem "rails":
    In Gemfile.rails-4.x:
      rails (~> 4.0)
  
      watir-rails was resolved to 2.2.2, which depends on
        rails (>= 3)

@eregon
Copy link
Member

eregon commented Dec 5, 2020

To clarify, this only affects Ruby 2.7+ which ships with Bundler 2, when there is no lockfile, and bundler: 1 is specified.

package.json Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@ojab ojab force-pushed the master branch 3 times, most recently from 9a05b4b to 62808f9 Compare December 5, 2020 11:46
@ojab
Copy link
Contributor Author

ojab commented Dec 5, 2020

index.js Outdated Show resolved Hide resolved
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ruby-head is coming with bundler-2 out of the box, so bundler: 1 is basically ignored
2 participants