✨ Add AppendUIDData and CopyUIDData classes #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't possible to convert
UIDPlusData
to useSequenceSet
internally, while still maintaining full backwards compatibility. So two new classes were added (AppendUIDData
andCopyUIDData
). The intention is to removeUIDPlusData
inv0.6.0
.AppendUIDData
andCopyUIDData
:SequenceSet
objects (not arrays of integers)data.size
to get the uid-set sizeCopyUIDData
:uid_mapping => source_uid_to_assigned_uid_hash
(This behaves identically to the existing
UIDPlusData#uid_mapping
.)copyuid.assigned_uid_for(source_uid) => assigned_uid
copyuid[source_uid] => assigned_uid
copyuid.source_uid_for(assigned_uid) => source_uid
copyuid.each_uid_pair
(aliases:each_pair
,each
)Although they are not perfectly compatible, upgrading from
UIDPlusData
toCopyUIDData
andAppendUIDData
should be relatively straightforward.This PR only adds the classes, but they are unused. For backward compatibility, a parser config option is needed in order to replace
UIDPlusData
with them. That was split into a separate PR (mostly just to simplify the release notes generation):APPENDUID
/COPYUID
, 🗑️ Deprecate UIDPlusData #401