Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit flaky test with macOS platform #389

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Omit flaky test with macOS platform #389

merged 2 commits into from
Jan 31, 2025

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 30, 2025

For #287

OpenSSL::SSL::SSLError is raised at 13/69 times in my macOS box. I always retried all of test suite of ruby/ruby everyday.

I know we should resolve this with root causes. But I have not enough time to investigate this.

And I got the following timeout issue with 4 times.

#<Thread:0x00000003236f3850 /Users/hsbt/Documents/github.com/ruby/ruby/gems/src/net-imap/test/net/imap/fake_server/test_helper.rb:10 run> terminated with exception (report_on_exception is true):
/Users/hsbt/Documents/github.com/ruby/ruby/lib/timeout.rb:40:in 'Timeout::Error.handle_timeout': execution expired (Timeout::Error)

I extend that timeout value to handle that.

I didn't get test failed running with ten times after applying above two workarounds.

hsbt added a commit to hsbt/ruby that referenced this pull request Jan 30, 2025
hsbt added a commit to ruby/ruby that referenced this pull request Jan 30, 2025
@nevans
Copy link
Collaborator

nevans commented Jan 31, 2025

@hsbt This is reasonable.

@nevans nevans merged commit a4f98ba into master Jan 31, 2025
37 checks passed
@nevans nevans deleted the omit-flaky-test branch January 31, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants