Omit nesting_level, use indent_level to build prompt string #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The document comment says that the part
%i
of the prompt is indent_level.irb/lib/irb.rb
Lines 182 to 192 in 1159c13
This pull request removes calculation of nesting_level introduced in #500 and #515 and use indent_level for building prompt string.
Concerns
In
test_ruby_lex.rb
, the wordnesting_level
is used instead ofindent_level
.But if we want
nesting_level
in prompt string again, we can easily re-implement it like this