Open Lamprey to configuration #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Lamprey configurable, beginning with a simple repository type configuration option. Adds command line arguments with `OptionParser`.
|
Partially closes #21. Remaining configuration needed to pass initialization options to custom repositories. |
|
cc: @mjsuhonos I wonder if you have time for design feedback on this? |
|
Will have time this Friday or sometime after next Monday. Desperate to pick this work back up, but in the middle of some big changes at the moment.
… On Jan 30, 2017, at 8:23 PM, Thomas Johnson ***@***.***> wrote:
cc: @mjsuhonos I wonder if you have time for design feedback on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@mjsuhonos wondering whether you're still figuring on finding time to review this. If not, I'm fairly happy with the result and will just merge it. :) |
|
Sorry for the delay; 👍 looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Lamprey configurable, beginning with a simple repository type configuration option. Adds command line arguments with
OptionParser.