Invalid body parse error not rescued by handlers #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a2ddac to
6edfbea
Compare
| @@ -81,6 +81,9 @@ def read_rack_input(body) | |||
| end | |||
| env['rack.request.form_input'] = env['rack.input'] | |||
| end | |||
| rescue MultiJson::ParseError | |||
There was a problem hiding this comment.
This is specific to the JSON parser, so it should be in it, not here. Then you can raise a Grape::Exception::InvalidMessageBody error and re-rescue and just re-raise anything that is Grape::Exception::Base here.
You might want to look at other parsers while you're at it, maybe the XML one has a similar problem and can be fixed in the same way?
|
This is good work, see my comments. |
ef1fd15 to
f69ded9
Compare
|
Found (and fixed) the same issue to appear when using the XML parser. |
| @@ -9,6 +9,7 @@ Next Release | |||
| * [#901](https://github.com/intridea/grape/pull/901): Fix: callbacks defined in a version block are only called for the routes defined in that block - [@kushkella](https://github.com/kushkella). | |||
| * [#886](https://github.com/intridea/grape/pull/886): Group of parameters made to require an explicit type of Hash or Array - [@jrichter1](https://github.com/jrichter1). | |||
| * [#912](https://github.com/intridea/grape/pull/912): Extended the `:using` feature for param documentation to `optional` fields - [@croeck](https://github.com/croeck). | |||
| * [#906](https://github.com/intridea/grape/pull/906): Fix: invalid body parse errors are not rescued by handlers [@croeck](https://github.com/croeck). | |||
There was a problem hiding this comment.
Nitpick: this is missing a dash. before your github name.
|
See my minor comments. Will merge after, great work. |
… error that translates into a customized bad request response (+spec)
f69ded9 to
3479ba0
Compare
|
Ok, fixed your comments and the build just passed :) |
dblock
added a commit
that referenced
this pull request
Jan 31, 2015
…ued-by-handlers Invalid body parse error not rescued by handlers
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see issue #904 for a more detailed description. The spec with content_type
application/jsonfails and is not processed byrescue_from :all.