Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test case catch-all route - #1081 #1089

Closed
wants to merge 1 commit into from

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Aug 4, 2015

No description provided.

@dblock
Copy link
Member

dblock commented Aug 4, 2015

This looks like a succeeding test :)

@wagenet
Copy link
Contributor Author

wagenet commented Aug 4, 2015

Ok... that's odd. It failed for me locally.

@wagenet
Copy link
Contributor Author

wagenet commented Aug 4, 2015

% rspec spec/grape/api_spec.rb:483                                                                                                  
Run options: include {:locations=>{"./spec/grape/api_spec.rb"=>[483]}}

Grape::API
  .route
    allows for catch-all in a namespace (FAILED - 1)

Failures:

  1) Grape::API.route allows for catch-all in a namespace
     Failure/Error: expect(last_response.body).to eql 'catch-all'

       expected: "catch-all"
            got: ""

       (compared using eql?)
     # ./spec/grape/api_spec.rb:508:in `block (3 levels) in <top (required)>'

Finished in 0.0718 seconds (files took 0.56025 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/grape/api_spec.rb:483 # Grape::API.route allows for catch-all in a namespace

@dblock
Copy link
Member

dblock commented Aug 4, 2015

Oh it doesn't look like anything ran?!

@wagenet
Copy link
Contributor Author

wagenet commented Aug 4, 2015

@dblock I just rebased on master to get a new push. I'm still not seeing anything running. Is your integration busted?

@dblock
Copy link
Member

dblock commented Aug 4, 2015

That would make sense, since we moved repo owners! Fixing.

@wagenet
Copy link
Contributor Author

wagenet commented Aug 5, 2015

Now tests fail :)

@dblock
Copy link
Member

dblock commented Aug 5, 2015

Success! 👍 :)

@dblock
Copy link
Member

dblock commented Apr 1, 2016

I believe this is fixed with the new router, @wagenet can you rerun these against HEAD please?

@wagenet
Copy link
Contributor Author

wagenet commented Apr 6, 2016

@dblock I've rebased. Test is still failing.

@dblock
Copy link
Member

dblock commented Apr 6, 2016

Thanks @wagenet, @namusyaka if you have a moment I couldn't figure out what's wrong here.

@namusyaka namusyaka self-assigned this Sep 23, 2016
namusyaka added a commit that referenced this pull request Nov 5, 2016
namusyaka added a commit that referenced this pull request Nov 5, 2016
namusyaka added a commit that referenced this pull request Nov 6, 2016
@dblock dblock closed this in 499f6c6 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants