added support for nicknamed routes #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require 'spec_helper' | ||
|
|
||
| describe 'a nicknamed mounted api' do | ||
| before :all do |
|
|
||
| describe 'a nicknamed mounted api' do | ||
| before :all do | ||
| class NicknamedMountedApi < Grape::API |
There was a problem hiding this comment.
also should be Class.new(Grape::API) do, thanks
| require 'spec_helper' | ||
|
|
||
| describe 'a nicknamed mounted api' do | ||
| def app |
There was a problem hiding this comment.
just use let!(:app) do instead method definition
|
Thanks, do not forget fix rubocop errors, you can try fix this automatically via /cc @LeFnord |
|
👍 … I really like it … filling the skeleton with functionality |
|
@pbendersky thanks, now you need add this feature to |
|
@Bugagazavr fix or feature? I'm leaning towards fix, as it's in the README, but I can see it as a feature as well. |
|
@pbendersky you can add this as fix. |
|
All set then! |
|
Great job, thanks again |
| @@ -9,6 +9,7 @@ | |||
| * [#476](https://github.com/ruby-grape/grape-swagger/pull/476): Fixes for handling the parameter type when body parameters are defined inside desc block - [@anakinj](https://github.com/anakinj). | |||
| * [#478](https://github.com/ruby-grape/grape-swagger/pull/478): Refactors building of properties, corrects documentation of array items - [@LeFnord](https://github.com/LeFnord). | |||
| * [#479](https://github.com/ruby-grape/grape-swagger/pull/479): Fix regex for Array and Multi Type in doc_methods. Parsing of "[APoint]" should return "APoint" - [@frodrigo](https://github.com/frodrigo). | |||
| * [#483](https://github.com/ruby-grape/grape-swagger/pull/483): Added support for nicknamed routes - [@pbendersky](https://github.com/pbendersky) | |||
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* added support for nicknamed routes * uses let instead of method to instantiate the app * updated spec to use anon class * fixed rubocop errors * Refactor to fix rubocop issues. * Added entry in Changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for nicknamed routes (fixes #481)