Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation with example of base_path proc #442

Merged
merged 3 commits into from
May 31, 2016
Merged

Update documentation with example of base_path proc #442

merged 3 commits into from
May 31, 2016

Conversation

Lordnibbler
Copy link
Contributor

@Lordnibbler Lordnibbler mentioned this pull request May 29, 2016
Merged
dblock
dblock reviewed May 29, 2016
View reviewed changes
README.md

```ruby
add_swagger_documentation \
base_path: proc { |foo| foo.host =~ /^example/ ? '/api-example' : '/api' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo here should be request

@Lordnibbler
Copy link
Contributor Author

@dblock updated! Thanks for the suggestions. I also updated the test where I copied that foo request object from!

@dblock dblock merged commit e47c679 into ruby-grape:master May 31, 2016
@dblock
Copy link
Member

dblock commented May 31, 2016

Thanks, merged.

LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@Lordnibbler @dblock
Update documentation with example of base_path proc (ruby-grape#442)
1b5426d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lordnibbler @dblock