-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades to grape 0.14.x; grape-entity 0.5.x #336
Conversation
Thanks. Fix CI please ( |
51c8aaa
to
729de7b
Compare
please merge so that I can work on, is it possible to cut off my fork and branch from this one, so that I can work on my fork the failed builds are rubinius, could not find a binary of it |
include_context "the api entities" | ||
|
||
before :all do | ||
module TheApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, however these classes will be declared globally, you might want to change it to a dynamic class, like Class.new(Grape::API)
or namespace them with something closer to the spec name, like module ContentTypeSpec ...
.
This is great, lets try to finish it.
|
thanks for the response, I'll try to do it in the next hours … to your questions:
a last question: can I change the version to something starting with 0.2.x, to indicate, breaking changes, |
Next version should be 0.11.0, you can update that. Don't worry about tagging, I'll cut a release once we have everything on green. |
58620fc
to
9e22931
Compare
removes pry runs under 2.3 updates gems, corrects parameter, which is in array, make rubocop happy fixes jruby build changes for TravisCI
This is looking good. Should I merge this? Squash commits? Update CHANGELOG? |
you can merge it, if you want 😄 for the next work, I want to merge this work into my fork (there it is master), next work should be:
is it ok for you? |
upgrades to grape 0.14.x; grape-entity 0.5.x
I merged this one. I am down with a PR into master that looks like it could actually ship. The biggest concerns for me are UPGRADING, README and CHANGELOG, where people know what they are getting. |
thanks for merging |
It's your master :) |
upgrades to grape 0.14.x; grape-entity 0.5.x
No description provided.