Fixed model inclusion in models with aliased references #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an entity has a field with an alias and it references another entity, the latter won't be included in the model's list.
Entity example:
The doc generated for an action using this entity will include the
AliasedThing
model but not theSomething
model.That's because when the
models_with_included_presenters
method fails to match aliased fields. When it's looking in each models, it tries to match fields frommodel.exposure
andmodel.documentation
. Butmodel.exposure
returns the primary name as key, andmodel.documentation
returns the aliased name as key. That's why they don't match.Here's my proposition for a fix. It's also a refactoring; I think it would be simpler to iterate just
model.exposure
and check for a:documentation
key.