combined global models with endpoint entities #128
Conversation
| @@ -11,6 +11,7 @@ | |||
| * Added Rubocop, Ruby-style linter - [@dblock](https://github.com/dblock). | |||
| * [#126](https://github.com/tim-vandecasteele/grape-swagger/pull/126): Rewritten demo in the `test` folder with CORS enabled - [@dblock](https://github.com/dblock). | |||
| * [#127](https://github.com/tim-vandecasteele/grape-swagger/pull/127): Fixed `undefined method 'reject' for nil:NilClass` error for an invalid route, now returning 404 Not Found - [@dblock](https://github.com/dblock). | |||
| * Combine global models and endpoint entities | |||
There was a problem hiding this comment.
Amend with the format above please, PR + your name. Thx.
There was a problem hiding this comment.
I did, hope it's better now. But this workflow has it's disadvantages. I have first to create a PR before I can change the CHANGELOG.md. Is there a better way?
There was a problem hiding this comment.
I personally don't know of a better way, but I am open to suggestions.
There was a problem hiding this comment.
Is some thing like this available for ruby?
There was a problem hiding this comment.
Yes, but I found these changelogs painful as the maintainers constantly complain to people to squash commits and make the descriptions really readable, transferring the burden from editable 1-liners to crazy policing of linux-kernel-like descriptions. I don't want to have to yell at people like Linus :)
There was a problem hiding this comment.
github-changes can use the PR name instead of the commit messages. Maybe it's a try worth. With the actual way you have to yell at people to add the PR into the changelog ;)
…_enities combined global models with endpoint entities
|
Thanks! |
Global models override entities defined with an endpoint. I think it's preferable to combine these models.