Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ostruct to gemspec dependencies #122

Closed
wants to merge 0 commits into from
Closed

Conversation

padde
Copy link
Contributor

@padde padde commented Sep 11, 2024

Fixes #121

This gem was historically included in the default gemset. Starting with Ruby 3.3.5 though, requiring ostruct without explicitly adding it as dependency generates the following warning:

warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of grape-swagger-rails-0.5.0 to request adding ostruct into its gemspec.

@dblock
Copy link
Member

dblock commented Sep 11, 2024

@padde Thanks! Will you please add Ruby 3.3 to CI and make sure it passes? https://github.com/ruby-grape/grape-swagger-rails/blob/master/.github/workflows/test.yml

@grape-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#122](https://github.com/ruby-grape/grape-swagger-rails/pull/122): Add ostruct to gemspec dependencies - [@padde](https://github.com/padde).

Generated by 🚫 Danger

@padde
Copy link
Contributor Author

padde commented Sep 11, 2024

Thanks @dblock

I think a lot of specs are failing here because with Rails 7, calling warn on the singleton instance of ActiveSupport::Deprecation is, well... deprecated. See rails/rails#47354

I will first work on that.

@dblock
Copy link
Member

dblock commented Sep 11, 2024

Thanks, lmk if you need help. Let's have a matrix with various rails versions eventually too.

@padde
Copy link
Contributor Author

padde commented Sep 11, 2024

For reference: #124

@padde
Copy link
Contributor Author

padde commented Sep 11, 2024

@dblock good point about the CI matrix, I did that as well but in a separate PR: #125

@padde
Copy link
Contributor Author

padde commented Sep 12, 2024

And finally, this PR will then fix compatibility with the upcoming Ruby 3.5 release: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings regarding ostruct on Ruby >= 3.3.5
3 participants