Add support for minItems, maxItems and uniqueItems #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e63604e to
ee3f775
Compare
kzaitsev
reviewed
Nov 25, 2018
|
@Bugagazavr agreed, let's use GitHub failed (a bit) committing the suggestions, I'll rebase / squash by hand. |
Fixes the PerceivedComplexity in #call: > lib/grape-swagger/entity/attribute_parser.rb:10:7: C: > Metrics/PerceivedComplexity: Perceived complexity for call is too high. [17/16]
1f10e17 to
22d2272
Compare
|
@Bugagazavr done, let me know if more changes are necessary. Fixed a few more typos 😱 and DRY'ed code to |
|
Thank you |
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
minItems,maxItemsanduniqueItemsforArrays(is_array: true) as described in theSchema Objectof the OpenAPI 2.0 specification.The
grape-entitydocumentation mentions that thedocumentationbubbles up but this is not the case for the above attributes.