Introduce recovery_failed callback #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s possible to specify the recovery_attempts option. Hitting the recovery attempts limit without a successful recovery leads to a cleanup of connection, etc. However, the client is not informed about this state and has no chance to react upon it. Here we introduce a callback which is called in exactly the above described situation enabling client code to react to a failed recovery process.
michaelklishin
requested changes
Jun 9, 2023
There was a problem hiding this comment.
Thank you for taking the time co contribute.
"recovery_failed" to me suggests that this callback will be used for every unsuccessful recovery attempts. If that's not the case, we should rename it "recovery_attemtps_exhausted" or something that clearly suggests that this callable will be invoked only once
for a series for unsuccessful recovery attempts.
|
Yeah, I agree. That name is much better! |
The former name implied that the hook would be executed on every recovery attempt failing. Renaming it to ‘recovery_attempts_exhausted’ will make things much clearer.
michaelklishin
approved these changes
Jun 9, 2023
|
@Schmitze333 thank you for contributing to Bunny! |
|
I did not provide a Changelog entry. Will that happen on the release or shall I add one? |
|
I update the change log before every release if necessary. Don't worry about it. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s possible to specify the recovery_attempts option on the Bunny::Session.
Hitting the recovery attempts limit without a successful recovery leads to a cleanup of connection, etc.
However, the client is not informed about this state and has no chance to react upon it.
This PR introduces a callback which is executed in exactly the above described situation enabling client code to react to a failed recovery process.
Relates to: #665