Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginfy RuboCop Rake #58

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Pluginfy RuboCop Rake #58

merged 1 commit into from
Feb 15, 2025

Conversation

koic
Copy link
Member

@koic koic commented Feb 14, 2025

This PR makes RuboCop Rake support RuboCop's Plugin feature.

It replaces the ad-hoc Inject with RuboCop plugins introduced in RuboCop 1.72. Additionally, since RuboCop already requires Ruby 2.7 or higher as its runtime, the required_ruby_version will be updated to 2.7.

Follow-up rubocop/rubocop#13792

@koic koic force-pushed the plugin_lint_roller branch from 2028fa6 to a6d2daa Compare February 15, 2025 17:59
This PR makes RuboCop Rake support RuboCop's Plugin feature.

It replaces the ad-hoc `Inject` with RuboCop plugins introduced in RuboCop 1.72.
Additionally, since RuboCop already requires Ruby 2.7 or higher as its runtime,
the `required_ruby_version` will be updated to 2.7.

Follow-up rubocop/rubocop#13792
@koic koic force-pushed the plugin_lint_roller branch from a6d2daa to 658715c Compare February 15, 2025 18:06
@koic koic merged commit 9a21bfd into rubocop:master Feb 15, 2025
8 checks passed
@koic koic deleted the plugin_lint_roller branch February 15, 2025 18:11
koic added a commit to rubocop/rubocop that referenced this pull request Feb 15, 2025
This commit uses plugified RuboCop Rake (0.7.0) for development and suppresses the following warning:

```console
$ bundle exec rubocop
rubocop-rake extension supports plugin, specify `plugins: rubocop-rake`
instead of `require: rubocop-rake` in /Users/koic/src/github.com/rubocop/rubocop/.rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.
```

Follow-up to rubocop/rubocop-rake#58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant