Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #205] Update Performance/ConstantRegexp to allow memoized regexps #206

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

dvandersluis
Copy link
Member

Fixes #205.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Contributor

@marcandre marcandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@koic koic merged commit 4e26952 into rubocop:master Jan 12, 2021
@koic
Copy link
Member

koic commented Jan 12, 2021

Nice 👍

koic added a commit that referenced this pull request Jan 18, 2021
Follow #206.

RuboCop Performance does not support `<<next>>` label.
patrickm53 pushed a commit to patrickm53/performance-develop-rubyonrails that referenced this pull request Sep 23, 2022
Follow rubocop/rubocop-performance#206.

RuboCop Performance does not support `<<next>>` label.
richardstewart0213 added a commit to richardstewart0213/performance-build-Performance-optimization-analysis- that referenced this pull request Nov 4, 2022
Follow rubocop/rubocop-performance#206.

RuboCop Performance does not support `<<next>>` label.
Cute0110 added a commit to Cute0110/Rubocop-Performance that referenced this pull request Sep 28, 2023
Follow rubocop/rubocop-performance#206.

RuboCop Performance does not support `<<next>>` label.
SerhiiMisiura added a commit to SerhiiMisiura/Rubocop-Performance that referenced this pull request Oct 5, 2023
Follow rubocop/rubocop-performance#206.

RuboCop Performance does not support `<<next>>` label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance/ConstantRegexp with a constant defined in a subclass
3 participants