Make RuboCop Capybara work as a RuboCop plugin #144
Conversation
|
@koic I tried replicating your pull requests rubocop/rubocop-performance#490 and rubocop/rubocop-rspec#2042, but both locally and on CI I find that The error suggests that the rubocop-capybara cops is being run, even though they are not listed under I have a similar branch with similar changes in rubocop-factory_bot, and the same thing happens – exceptions from one of the |
ce4cd36 to
8895af6
Compare
This pull request adds support for RuboCop's plugin feature, added in rubocop/rubocop#13792, released in v1.72. It replaces the ad-hoc `inject_defaults!` with RuboCop plugins. Some Rake tasks may still need to use `inject_defaults!`.
8895af6 to
a974f3b
Compare
| RuboCop::RakeTask.new(:internal_investigation) do | ||
| RuboCop::ConfigLoader.inject_defaults!("#{__dir__}/config/default.yml") | ||
| end |
There was a problem hiding this comment.
I don’t understand why this is necessary, and hope to remove it before merging the PR.
This pull request adds support for RuboCop's plugin feature, added in rubocop/rubocop#13792, released in v1.72.
It replaces the ad-hoc
inject_defaults!with RuboCop plugins.Some Rake tasks may still need to use
inject_defaults!.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).