Add anchors to all bullets #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similiar to the formatting used in rubocop/ruby-style-guide#338 and was requested by @bbatsov to be applied to this Rails guide as well. Much easier the second time around. :)
|
👍 Excellent work! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to the formatting used in rubocop/ruby-style-guide/pull/338 and was requested by @bbatsov to be applied to this Rails guide as well. Every bullet is anchored with a short
<a name>tag and includes a superscript[link]anchor at the end.Much easier the second time around. :)
I find the individual commits easier when it comes to reading diffs (to make sure I'm not sneaking bad advice into this guide). If you'd care you, take a look at https://github.com/rapid7/rails-style-guide/tree/add-anchors-rails to see the individual commits. d528e95 is simply a squash commit of that branch.