forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fl-1241 - integrated video bid support into rubicon adapter. Updated … #7
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
23045c1
fl-1241 - integrated video bid support into rubicon adapter. Updated …
2169d04
fl-1241 - Updates based on pull request comments
199b690
added a few stylistic and consolidation changes to rubicon adapter
snapwich 378e4a6
allow rubicon adapter to get video size from adunit and fix timeout
snapwich ac0af12
add unit tests for rubicon video
snapwich ca856c9
fl-1241 - Fixed bug in how size_id was added to slot object - updated…
3760312
fl-1241 -Rolled back size_id fix and test update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might split out the validation of the response by type that way we can still do these checks for non-video and then video can have a different set of response validations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these checks are identical for both display and video. Only difference was grabbing the video ads response correctly from frankenstein which comes back as an objet and not an array directly because it implements SRA. If further individual validation becomes necessary in the future, we can break it out based on mediaType.