CON-200: Fix double free segfault (#79)

* CON-200: Fix double free segfault

* Update test/python/test_rticonnextdds_connector.py

Co-authored-by: Alex Campos <alejandro@rti.com>

Co-authored-by: Sam Raeburn <sam@rti.com>
Co-authored-by: Alex Campos <alejandro@rti.com>

rticonnextdds_connector/rticonnextdds_connector.py

@@ -173,7 +173,7 @@ def __init__(self): # pylint: disable=too-many-statements
         self.new.argtypes = [ctypes.c_char_p, ctypes.c_char_p, ctypes.c_void_p]
 
         self.delete = self.library.RTI_Connector_delete
-        self.delete.restype = ctypes.c_void_p
+        self.delete.restype = None
         self.delete.argtypes = [ctypes.c_void_p]
 
         self.get_writer = self.library.RTI_Connector_get_datawriter
@@ -1255,8 +1255,8 @@ def __init__(self, config_name, url):
 
     def close(self):
         """Frees all the resources created by this Connector instance"""
-
         connector_binding.delete(self.native)
+        self.native = 0
 
     # Deprecated: use close()
     # pylint: disable=missing-docstring

test/python/test_rticonnextdds_connector.py

@@ -105,3 +105,16 @@ def test_connector_creation_with_participant_qos(self):
                 config_name=participant_profile,
                 url=xml_path) as connector:
             assert connector is not None
+
+    def test_connector_double_deletion(self):
+        """Verify CON-200, that Connector does not segfault on double deletion"""
+        participant_profile = "MyParticipantLibrary::ConnectorWithParticipantQos"
+        xml_path = os.path.join(os.path.dirname(
+                os.path.realpath(__file__)),
+                "../xml/TestConnector.xml")
+        with rti.open_connector(
+                config_name=participant_profile,
+                url=xml_path) as connector:
+            assert connector is not None
+            connector.close()
+        # connector.close() will be called again here due to the with clause