Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a URL containing a port when using HTTP/3 doesn't work; the port is ignored. #1139

Closed
bwelling opened this issue Oct 3, 2024 · 1 comment

Comments

@bwelling
Copy link
Collaborator

bwelling commented Oct 3, 2024

Describe the bug

Specifying a URL containing a port when using HTTP/3 doesn't work; the port is ignored.

To Reproduce

import dns.message
import dns.query

url = 'https://example.com:10443/dns-query'
m = dns.message.make_query('google.com', 'A')
r = dns.query.https(m, url, verify=False, bootstrap_address='127.0.0.1', http_version=3)
print(r)

This should send a query to port 10443; it actually sends a query to port 443. With http_version=2, it correctly sends to the alternate port.

Context

  • dnspython master branch
  • Python 3.12.3
  • macOS Sonoma
rthalley added a commit that referenced this issue Oct 5, 2024
@rthalley
Copy link
Owner

rthalley commented Oct 5, 2024

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants