Add support for sticky ad #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtBot
requested changes
Jan 23, 2020
rtBot
requested changes
Jan 24, 2020
rtBot
requested changes
Jan 24, 2020
sagarnasit
reviewed
Jan 24, 2020
classes/class-amp-admanager.php
Outdated
Comment on lines
475
to
477
| 'desktop-sizes' => '600x90,728x90', | ||
| 'tablet-sizes' => '320x50,468x60', | ||
| 'mobile-sizes' => '320x50,468x60', |
There was a problem hiding this comment.
sizes should be dynamic instead of static, right? I see the discussion is going on #59
cc: @pradeep910
There was a problem hiding this comment.
Yes sizes should be dynamic, and override with these *-sizes parameters.
rtBot
requested changes
Jan 28, 2020
pradeep910
reviewed
Jan 30, 2020
template-parts/amp-resources.php
Outdated
| <script type="text/javascript" src="https://cdn.ampproject.org/v0.js" async></script> | ||
| <script async custom-element="amp-sticky-ad" src="https://cdn.ampproject.org/v0/amp-sticky-ad-1.0.js"></script> |
There was a problem hiding this comment.
There should be a check here if sticky ad is enabled, then only include this script.
rtBot
requested changes
Jan 30, 2020
|
Addressed feedbacks |
rtBot
requested changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #59