Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #158

Merged
merged 9 commits into from
Aug 28, 2016
Merged

v4 #158

merged 9 commits into from
Aug 28, 2016

Conversation

rt2zz
Copy link
Owner

@rt2zz rt2zz commented Aug 28, 2016

  • support immutable state ( 🎈 thanks @rufman )
  • return Promises in default storage engines
  • return Promise from purge methods

@rufman thanks for the great work on supporting immutable from #113 and I apologize for taking so long to get it merged in! since it requires a full 5 extra config options, I propose the following: Lets release a new module redux-persist-immutable which wraps redux-persist and proxies in the necessary config as well as well as the redux-persist-transform-immutable transform.

Towards this end, I renamed the config options from e.g. config.stateSetter to config._stateSetter, since the intended usage is via a proxy module (or a higher order module if you will).

Let me know your thoughts. I am still working on a few more tweaks and adding more tests in preparation for v4, I hope to cut a release this week.

cc/ @corbt @marvinhagemeister @rufman

@rt2zz
Copy link
Owner Author

rt2zz commented Aug 28, 2016

Also this adds promise support for purge #119 and static purgeStoredState export #127

@rt2zz rt2zz merged commit 7ca410b into master Aug 28, 2016
@rt2zz rt2zz removed the in progress label Aug 28, 2016
@rufman
Copy link
Contributor

rufman commented Aug 28, 2016

@rt2zz Yeah I think not exposing any of those options directly is a good idea. I'll look at starting an implementation of a "higher order library" this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants