-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
軌道生成の失敗時にpick_and_placeを中断する機能を追加 #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
少しコメントしました。
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメント書きました。
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 軌道生成の失敗時にpick_and_placeを中断する機能を追加 * if文の括弧の位置を修正 * 可読性を高めるために1を定数に置き換える * 一行が長過ぎるので二行に分ける * if文を三行に分ける * if文のスペース調整 * アーム動作失敗時のコメントを修正 Co-authored-by: Kuwamai <kuwagata@rt-net.jp> * control_arm関数の返り値をbool型に変更 * control_arm関数の返り値を修正 Co-authored-by: Kuwamai <kuwagata@rt-net.jp> --------- Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
* 軌道生成の失敗時にpick_and_placeを中断する機能を追加 (#65) * 軌道生成の失敗時にpick_and_placeを中断する機能を追加 * if文の括弧の位置を修正 * 可読性を高めるために1を定数に置き換える * 一行が長過ぎるので二行に分ける * if文を三行に分ける * if文のスペース調整 * アーム動作失敗時のコメントを修正 Co-authored-by: Kuwamai <kuwagata@rt-net.jp> * control_arm関数の返り値をbool型に変更 * control_arm関数の返り値を修正 Co-authored-by: Kuwamai <kuwagata@rt-net.jp> --------- Co-authored-by: Kuwamai <kuwagata@rt-net.jp> * foxyでビルドが通るように定数を修正 --------- Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
What does this implement/fix?
軌道生成に失敗した時、pick_and_placeを中断して待機姿勢に戻る機能を追加します。
Does this close any currently open issues?
しません。
How has this been tested?
実機のCRANE+ V2で動作確認しました。
実行したコマンドは下記のとおりです。
Any other comments?
Checklists