Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

軌道生成の失敗時にpick_and_placeを中断する機能を追加 #65

Merged
merged 9 commits into from
Jul 27, 2023

Conversation

YusukeKato
Copy link
Collaborator

@YusukeKato YusukeKato commented Jul 26, 2023

What does this implement/fix?

軌道生成に失敗した時、pick_and_placeを中断して待機姿勢に戻る機能を追加します。

Does this close any currently open issues?

しません。

How has this been tested?

実機のCRANE+ V2で動作確認しました。

実行したコマンドは下記のとおりです。

# ターミナル1
ros2 launch crane_plus_examples demo.launch.py port_name:=/dev/ttyUSB0 use_camera:=true video_device:=/dev/video2
# ターミナル2
ros2 launch crane_plus_examples camera_example.launch.py example:='color_detection'

Any other comments?

Checklists

@YusukeKato YusukeKato requested a review from Kuwamai July 26, 2023 07:17
@YusukeKato YusukeKato self-assigned this Jul 26, 2023
@YusukeKato YusukeKato added the Type: Feature New Feature label Jul 26, 2023
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少しコメントしました。

crane_plus_examples/src/pick_and_place_tf.cpp Outdated Show resolved Hide resolved
crane_plus_examples/src/pick_and_place_tf.cpp Show resolved Hide resolved
crane_plus_examples/src/pick_and_place_tf.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメント書きました。

crane_plus_examples/src/pick_and_place_tf.cpp Outdated Show resolved Hide resolved
Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuwamai Kuwamai merged commit a248d25 into master Jul 27, 2023
@Kuwamai Kuwamai deleted the pick-and-place-interruption branch July 27, 2023 07:33
YusukeKato added a commit that referenced this pull request Jul 27, 2023
* 軌道生成の失敗時にpick_and_placeを中断する機能を追加

* if文の括弧の位置を修正

* 可読性を高めるために1を定数に置き換える

* 一行が長過ぎるので二行に分ける

* if文を三行に分ける

* if文のスペース調整

* アーム動作失敗時のコメントを修正

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>

* control_arm関数の返り値をbool型に変更

* control_arm関数の返り値を修正

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>

---------

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Kuwamai added a commit that referenced this pull request Jul 27, 2023
* 軌道生成の失敗時にpick_and_placeを中断する機能を追加 (#65)

* 軌道生成の失敗時にpick_and_placeを中断する機能を追加

* if文の括弧の位置を修正

* 可読性を高めるために1を定数に置き換える

* 一行が長過ぎるので二行に分ける

* if文を三行に分ける

* if文のスペース調整

* アーム動作失敗時のコメントを修正

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>

* control_arm関数の返り値をbool型に変更

* control_arm関数の返り値を修正

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>

---------

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>

* foxyでビルドが通るように定数を修正

---------

Co-authored-by: Kuwamai <kuwagata@rt-net.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants