Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz_ros2_control 0.1.5対応 #55

Merged
merged 5 commits into from
Jul 31, 2023
Merged

gz_ros2_control 0.1.5対応 #55

merged 5 commits into from
Jul 31, 2023

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Apr 11, 2023

What does this implement/fix?

gz_ros2_control 0.1.5からuse_sim_timeを有効にする必要があったためuse_sim_time、parameter_bridgeを追加しました。
関連PR: ros-controls/gz_ros2_control#100

Does this close any currently open issues?

しません

How has this been tested?

下記コマンドでシミュレータを起動し、RVizからマニピュレータの操作ができることを確認しました。

ros2 launch crane_plus_ignition crane_plus_ignition.launch.py

Any other comments?

clockの同期はシミュレータのclockをその他のノードに同期させるためparameter_bridgeの引数は以下のように記述する必要があります。

'/clock@rosgraph_msgs/msg/Clock[ignition.msgs.Clock'

関連issue: gazebosim/ros_gz#341

Checklists

@Kuwamai Kuwamai added the Type: Bug Bug or Bug fixes label Apr 11, 2023
@Kuwamai Kuwamai requested a review from ShotaAk April 11, 2023 07:43
@Kuwamai Kuwamai self-assigned this Apr 11, 2023
@Kuwamai Kuwamai changed the base branch from master to foxy-devel July 28, 2023 05:50
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけコメントしました

crane_plus_examples/README.md Outdated Show resolved Hide resolved
Kuwamai and others added 2 commits July 31, 2023 17:45
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 1af5047 into foxy-devel Jul 31, 2023
@ShotaAk ShotaAk deleted the add_use_sim_time branch July 31, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants