Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get thematic working with packages that use registerS3method() inside .onLoad() to register ggplot2 methods #91

Merged
merged 4 commits into from
Feb 19, 2021
Merged

Get thematic working with packages that use registerS3method() inside .onLoad() to register ggplot2 methods #91

merged 4 commits into from
Feb 19, 2021

Conversation

cpsievert
Copy link
Collaborator

Closes #90

@cpsievert
Close #90: Get thematic working with packages that use registerS3meth…
0cb0a1e 
…od() inside .onLoad() to register ggplot2 methods
@cpsievert cpsievert requested a review from wch February 17, 2021 01:17
@cpsievert cpsievert merged commit 1cf2120 into master Feb 19, 2021
@cpsievert cpsievert deleted the s3methods-matrix branch February 19, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch Awaiting requested review from wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thematic_on breaks if another package includes ggplot (maybe?)
1 participant
@cpsievert