-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
textInput()
, textAreaInput()
, numericInput()
, passwordInput()
: allow updating value on blur
#4183
base: main
Are you sure you want to change the base?
Changes from all commits
1219174
f27358c
170561a
9adf3c8
c93cb23
24668e3
372ab8f
3642080
a06d61a
37eda6f
0f0e4e5
085f104
8977a82
c9ba5f5
c070fe8
7ba1897
8f77bca
c907a58
d322976
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if some people will want to have a third option,
"enter"
? In that scenario, we'd allow multiple values forupdateOn
, so you could sayupdateOn = c("blur", "enter")
.That said, I prefer the implementation as it is now; I don't think in practice in Shiny apps it's a great idea to require pressing Enter in these inputs for the value to change, or if you do you should use an button (or we extract the shinychat text input into a standalone component).